Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace bech32 and old chacha with noble and scure packages #294

Merged
merged 6 commits into from
Sep 23, 2023
Merged

Conversation

paulmillr
Copy link
Contributor

#280 improved dependency situation a lot.

  • bech32 was replaced with audited @scure/base
  • @stablelib was replaced with @noble/ciphers

cc @ukstv

@ukstv
Copy link
Contributor

ukstv commented Sep 15, 2023

Amazing!!

@ukstv
Copy link
Contributor

ukstv commented Sep 15, 2023

CC @oed

Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this, and for all your other work too!
Code looks good, you'll need to update yarn.lock to make the CI checks pass.
BTW, do you plan an audit for @noble/ciphers too?

@paulmillr
Copy link
Contributor Author

yeah

@mirceanis mirceanis merged commit 853c799 into decentralized-identity:master Sep 23, 2023
1 check passed
uport-automation-bot pushed a commit that referenced this pull request Sep 23, 2023
# [7.3.0](7.2.8...7.3.0) (2023-09-23)

### Features

* **deps:** replace bech32 and old chacha with noble and scure packages ([#294](#294)) ([853c799](853c799))
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants